Import animation styles separate from general styles. #2576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtashjianjr-godaddy
previously requested changes
Nov 3, 2023
EvanHerman
reviewed
Nov 6, 2023
EvanHerman
reviewed
Nov 6, 2023
EvanHerman
reviewed
Nov 6, 2023
EvanHerman
reviewed
Nov 6, 2023
EvanHerman
reviewed
Nov 6, 2023
EvanHerman
reviewed
Nov 6, 2023
EvanHerman
reviewed
Nov 6, 2023
EvanHerman
reviewed
Nov 6, 2023
|
PR changes are working perfectly on my end, great work on that! Just some minor changes above and I think it's good to go. |
Co-authored-by: Evan Herman <[email protected]>
Co-authored-by: Evan Herman <[email protected]>
Co-authored-by: Evan Herman <[email protected]>
Co-authored-by: Evan Herman <[email protected]>
Co-authored-by: Evan Herman <[email protected]>
Co-authored-by: Evan Herman <[email protected]>
Co-authored-by: Evan Herman <[email protected]>
EvanHerman
approved these changes
Nov 6, 2023
EvanHerman
reviewed
Nov 6, 2023
AnthonyLedesma
dismissed
mtashjianjr-godaddy’s stale review
Attempted optimize but reverted as good enough for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moved Animation Styles. New Tests. New Workflow to test only on changed files. Bump to WP-next version.
Screenshots
Types of changes
Splitting styles apart into new Webpack compile.
Importing new styles always.
New tests to check for the condition of always-loaded styles.
New workflow for testing velocity.
How has this been tested?
Tested manually as well as new tests in CICD
Acceptance criteria
Should allow for animation to properly function on the Editor and Front end for all blocks, CoBlocks and Core.
Checklist: